Avoid calling onchange callback on sync event if property isn't changed

pennam · pennam · commit a4d0fbc5d042 · 2023-09-20T12:43:40.000+02:00
diff --git a/src/property/Property.cpp b/src/property/Property.cpp
@@ -394,8 +394,10 @@ void onAutoSync(Property & property) {
 }
 
 void onForceCloudSync(Property & property) {
-  property.fromCloudToLocal();
-  property.execCallbackOnChange();
+  if (property.isDifferentFromCloud()) {
+    property.fromCloudToLocal();
+    property.execCallbackOnChange();
+  }
 }
 
 void onForceDeviceSync(Property & /* property */) {

Original file line number	Diff line number	Diff line change
`@@ -394,8 +394,10 @@ void onAutoSync(Property & property) {`
`394`	`394`	`}`
`395`	`395`
`396`	`396`	`void onForceCloudSync(Property & property) {`
`397`		`- property.fromCloudToLocal();`
`398`		`- property.execCallbackOnChange();`
	`397`	`+ if (property.isDifferentFromCloud()) {`
	`398`	`+ property.fromCloudToLocal();`
	`399`	`+ property.execCallbackOnChange();`
	`400`	`+ }`
`399`	`401`	`}`
`400`	`402`
`401`	`403`	`void onForceDeviceSync(Property & /* property */) {`