-
-
Notifications
You must be signed in to change notification settings - Fork 911
feat(symfony): object mapper with state options #6801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\State\Processor; | ||
|
||
use ApiPlatform\Metadata\Operation; | ||
use ApiPlatform\State\ProcessorInterface; | ||
use Doctrine\Persistence\ManagerRegistry; | ||
use Symfony\Component\ObjectMapper\Attribute\Map; | ||
use Symfony\Component\ObjectMapper\ObjectMapperInterface; | ||
|
||
final class ObjectMapperProcessor implements ProcessorInterface | ||
{ | ||
public function __construct( | ||
private readonly ObjectMapperInterface $objectMapper, | ||
private readonly ProcessorInterface $decorated, | ||
) { | ||
} | ||
|
||
public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []): object|array|null | ||
{ | ||
if (!(new \ReflectionClass($operation->getClass()))->getAttributes(Map::class)) { | ||
return $this->decorated->process($data, $operation, $uriVariables, $context); | ||
} | ||
|
||
return $this->objectMapper->map($this->decorated->process($this->objectMapper->map($data, $context['data'] ?? null), $operation, $uriVariables, $context)); | ||
Check failure on line 36 in src/State/Processor/ObjectMapperProcessor.php
|
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\State\Provider; | ||
|
||
use ApiPlatform\Doctrine\Odm\State\Options as OdmOptions; | ||
use ApiPlatform\Doctrine\Orm\State\Options; | ||
use ApiPlatform\Metadata\Operation; | ||
use ApiPlatform\State\Pagination\ArrayPaginator; | ||
use ApiPlatform\State\Pagination\PaginatorInterface; | ||
use ApiPlatform\State\ProviderInterface; | ||
use Symfony\Component\ObjectMapper\Attribute\Map; | ||
use Symfony\Component\ObjectMapper\ObjectMapperInterface; | ||
|
||
final class ObjectMapperProvider implements ProviderInterface | ||
{ | ||
public function __construct( | ||
private readonly ObjectMapperInterface $objectMapper, | ||
private readonly ProviderInterface $decorated, | ||
) { | ||
} | ||
|
||
public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null | ||
{ | ||
$data = $this->decorated->provide($operation, $uriVariables, $context); | ||
|
||
if (!\is_object($data)) { | ||
return $data; | ||
} | ||
|
||
$entityClass = $operation->getClass(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The denormalizer provider is only called on write operations. but indeed they should be doctrine-oriented it would make more sense |
||
if (($options = $operation->getStateOptions()) && $options instanceof Options && $options->getEntityClass()) { | ||
$entityClass = $options->getEntityClass(); | ||
} | ||
|
||
if (($options = $operation->getStateOptions()) && $options instanceof OdmOptions && $options->getDocumentClass()) { | ||
$entityClass = $options->getDocumentClass(); | ||
} | ||
|
||
if (!(new \ReflectionClass($entityClass))->getAttributes(Map::class)) { | ||
return $data; | ||
} | ||
|
||
if ($data instanceof PaginatorInterface) { | ||
return new ArrayPaginator(array_map(fn ($v) => $this->objectMapper->map($v), iterator_to_array($data)), 0, \count($data)); | ||
} | ||
|
||
return $this->objectMapper->map($data); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?xml version="1.0" ?> | ||
|
||
<container xmlns="http://symfony.com/schema/dic/services" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
<services> | ||
<service id="api_platform.state_provider.object_mapper" class="ApiPlatform\State\Provider\ObjectMapperProvider" decorates="api_platform.state_provider.read"> | ||
<argument type="service" id="object_mapper" /> | ||
<argument type="service" id="api_platform.state_provider.object_mapper.inner" /> | ||
</service> | ||
|
||
<service id="api_platform.state_processor.object_mapper" class="ApiPlatform\State\Processor\ObjectMapperProcessor" decorates="api_platform.state_processor.locator"> | ||
<argument type="service" id="object_mapper" /> | ||
<argument type="service" id="api_platform.state_processor.object_mapper.inner" /> | ||
</service> | ||
</services> | ||
</container> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource; | ||
|
||
use ApiPlatform\Doctrine\Orm\State\Options; | ||
use ApiPlatform\JsonLd\ContextBuilder; | ||
use ApiPlatform\Metadata\ApiResource; | ||
use ApiPlatform\Tests\Fixtures\TestBundle\Entity\MappedEntity; | ||
use Symfony\Component\ObjectMapper\Attribute\Map; | ||
|
||
#[ApiResource(stateOptions: new Options(entityClass: MappedEntity::class), normalizationContext: [ContextBuilder::HYDRA_CONTEXT_HAS_PREFIX => false])] | ||
#[Map(target: MappedEntity::class)] | ||
final class MappedResource | ||
{ | ||
#[Map(if: false)] | ||
public ?string $id = null; | ||
|
||
#[Map(target: 'firstName', transform: [self::class, 'toFirstName'])] | ||
#[Map(target: 'lastName', transform: [self::class, 'toLastName'])] | ||
public string $username; | ||
|
||
public static function toFirstName(string $v): string | ||
{ | ||
return explode(' ', $v)[0] ?? null; | ||
} | ||
|
||
public static function toLastName(string $v): string | ||
{ | ||
return explode(' ', $v)[1] ?? null; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the API Platform project. | ||
* | ||
* (c) Kévin Dunglas <dunglas@gmail.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity; | ||
|
||
use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\MappedResource; | ||
use Doctrine\ORM\Mapping as ORM; | ||
use Symfony\Component\ObjectMapper\Attribute\Map; | ||
|
||
/** | ||
* MappedEntity to MappedResource. | ||
*/ | ||
#[ORM\Entity] | ||
#[Map(target: MappedResource::class)] | ||
class MappedEntity | ||
{ | ||
#[ORM\Column(type: 'integer')] | ||
#[ORM\Id] | ||
#[ORM\GeneratedValue(strategy: 'AUTO')] | ||
private ?int $id = null; | ||
|
||
#[ORM\Column] | ||
#[Map(if: false)] | ||
private string $firstName; | ||
|
||
#[Map(target: 'username', transform: [self::class, 'toUsername'])] | ||
#[ORM\Column] | ||
private string $lastName; | ||
|
||
public static function toUsername($value, $object): string | ||
{ | ||
return $object->getFirstName().' '.$object->getLastName(); | ||
} | ||
|
||
public function getId(): ?int | ||
{ | ||
return $this->id; | ||
} | ||
|
||
public function setLastName(string $name): void | ||
{ | ||
$this->lastName = $name; | ||
} | ||
|
||
public function getLastName(): string | ||
{ | ||
return $this->lastName; | ||
} | ||
|
||
public function setFirstName(string $name): void | ||
{ | ||
$this->firstName = $name; | ||
} | ||
|
||
public function getFirstName(): string | ||
{ | ||
return $this->firstName; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GromNaN this is probably fixing the issue you commented about the denormalizer.
Could you review again?