Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

OSPF: WIP formatting documentation for ospf #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agneya2001
Copy link

WIP: documentation for ospf

@GabrielBrascher
Copy link
Member

Hi @agneya2001, could you please consider the following suggestions?

  • Line 1453, change from "debian" to "Debian";
  • at lines 1476 and 1480, change from "Dhcp, Dns" to "DHCP, DNS"; also, modify from "A example" to "An example";
  • there are some lines with "Ospf" or "ospf", I would choose to keep with "OSPF".

Thanks.

@agneya2001
Copy link
Author

@GabrielBrascher all suggestions are good, made them for some i will have to tune the code, will do that too.

@pdion891
Copy link
Contributor

@agneya2001 , any update on the merge of your code in the upstream ?
I'm keeping this PR open until the actual code get merge into master

Regards,

@rafaelweingartner
Copy link
Member

@GabrielBrascher and @pdion891 what are your feedback here? +1 or -1?

@pdion891
Copy link
Contributor

pdion891 commented Apr 8, 2018

@rafaelweingartner, I think it's still a work in progress, I'm not aware this feature got merged into master yet.

@rafaelweingartner
Copy link
Member

You are right. I did not notice that. I checked that PR, and I do not believe that it will get ready any time soon.

@rohityadavcloud
Copy link
Member

The is still pending, we can leave both the doc and code PRs until they are resumed by someone in future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants