test(query-core): add test case for query #9145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 41eabff.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9145 +/- ##
===========================================
+ Coverage 45.00% 59.40% +14.40%
===========================================
Files 206 138 -68
Lines 8219 5464 -2755
Branches 1836 1459 -377
===========================================
- Hits 3699 3246 -453
+ Misses 4080 1921 -2159
+ Partials 440 297 -143 🚀 New features to boost your workflow:
|
TkDodo
reviewed
May 14, 2025
| expect(query.state.data).toBe('persisted data') | ||
| }) | ||
|
|
||
| test('should use queryFn from observer if not provided in options', async () => { |
There was a problem hiding this comment.
we could also assert here that query.options.queryFn is set to the one of the observer at the end.
There was a problem hiding this comment.
I reflected at 41eabff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved test coverage of
queryBefore
After