fix(ui5-side-navigation): group name is now announced by screen reader #11600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group name is read out when accessing group item. fixes: #11599
LidiyaGeorgieva
requested review from
TeodorTaushanov,
Stoev and
GerganaKremenska
Stoev
reviewed
May 28, 2025
There was a problem hiding this comment.
Looks good.
Could add "now" to stress the change:
group name is now announced by screen reader
If you consider of additional value for users, please add some explanatory text, for example:
Add aria-label={this.text} to the group ul elements in the Side Navigation templates, making navigation groups and sub-items more descriptive for screen readers.
LidiyaGeorgieva
changed the title
TeodorTaushanov
requested changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group name is read out when accessing group item.
fixes: #11599