Skip to content

Added link to the contact page #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added link to the contact page #8

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e3551c
added link to the contact page
laadysufiia Oct 8, 2020
c99d3e6
Fixed the link to the Contact page as it wasn't working as expected
laadysufiia Oct 8, 2020
b01546a
worked on the contact page
laadysufiia Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contact.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h1 class="">ProgrammerGaurav</h1>
<a title="SKills Navigation" class="nav-link" href="/#skills">Skills</a>
</li>
<li class="nav-item active">
<a title="Contact Navigation" class="nav-link" href="">Contact</a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the page itself is on contact.html so no need redirect again on contact.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right, I've edited the wrong file. You have an issue with the 'Contact' link on your nav bar, when you click it doesn't direct you to the contact page. I've fixed this now.

<a title="Contact Navigation" class="nav-link" href="/contact.html">Contact</a>
</li>
</ul>
</div>
Expand Down