Ilgonmic/2 module compilation #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No special error for compose wasm, because we have only one compose server
It works like separate static stdlib bundle, and one small dynamic So we could instantiate stdlib with skiko, and then instantiate and run main bundle with ready stdlib.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now wasm can compile only user code, and libraries are provided statically.
So server can return versions of skiko and stdlib (for stdlib hash is used). Then based on these "versions" playground has to get static files from static server, versions are necessary for caching.
The all wasm files are instantiated correctly