Skip to content

fix(input-group): remove unused interim-bottom-line-color property #15854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 20.0.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@
"version": "20.0.0",
"description": "Updates Ignite UI for Angular from v19.2.0 to v20.0.0",
"factory": "./update-20_0_0"
},
"migration-47": {
"version": "20.0.2",
"description": "Updates Ignite UI for Angular from v20.0.0 to v20.0.2",
"factory": "./update-20_0_2"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
"remove": true,
"owner": "grid-summary-theme",
"type": "property"
},
{
"name": "$interim-bottom-line-color",
"remove": true,
"owner": "input-group-theme",
"type": "property"
}
]
}
20 changes: 20 additions & 0 deletions projects/igniteui-angular/migrations/update-20_0_0/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,24 @@ describe(`Update to ${version}`, () => {
);`
);
});

it('should remove the $interim-bottom-line-color property from the input-group theme', async () => {
const testFilePath = `/testSrc/appPrefix/component/test.component.scss`;

appTree.create(
testFilePath,
`$my-input-group-theme: input-group-theme(
$box-background: #ccc,
$interim-bottom-line-color: orange,
);`
);

const tree = await schematicRunner.runSchematic(migrationName, {}, appTree);

expect(tree.readContent(testFilePath)).toEqual(
`$my-input-group-theme: input-group-theme(
$box-background: #ccc,
);`
);
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$schema": "../../common/schema/theme-changes.schema.json",
"changes": [
{
"name": "$interim-bottom-line-color",
"remove": true,
"owner": "input-group-theme",
"type": "property"
}
]
}
37 changes: 37 additions & 0 deletions projects/igniteui-angular/migrations/update-20_0_2/index.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import * as path from 'path';

import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
import { setupTestTree } from '../common/setup.spec';

const version = '20.0.2';

describe(`Update to ${version}`, () => {
let appTree: UnitTestTree;
const schematicRunner = new SchematicTestRunner('ig-migrate', path.join(__dirname, '../migration-collection.json'));

beforeEach(() => {
appTree = setupTestTree();
});

const migrationName = 'migration-47';

it('should remove the $interim-bottom-line-color property from the input-group theme', async () => {
const testFilePath = `/testSrc/appPrefix/component/test.component.scss`;

appTree.create(
testFilePath,
`$my-input-group-theme: input-group-theme(
$box-background: #ccc,
$interim-bottom-line-color: orange,
);`
);

const tree = await schematicRunner.runSchematic(migrationName, {}, appTree);

expect(tree.readContent(testFilePath)).toEqual(
`$my-input-group-theme: input-group-theme(
$box-background: #ccc,
);`
);
});
});
14 changes: 14 additions & 0 deletions projects/igniteui-angular/migrations/update-20_0_2/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import type {
Rule,
SchematicContext,
Tree
} from '@angular-devkit/schematics';
import { UpdateChanges } from '../common/UpdateChanges';

const version = '20.0.2';

export default (): Rule => async (host: Tree, context: SchematicContext) => {
context.logger.info(`Applying migration for Ignite UI for Angular to version ${version}`);
const update = new UpdateChanges(__dirname, host, context);
update.applyChanges();
};
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
/// @param {Color} $idle-bottom-line-color [null] - The bottom line and border colors in the idle state.
/// @param {Color} $hover-bottom-line-color [null] - The bottom line and border colors in the hover state.
/// @param {Color} $focused-bottom-line-color [null] - The bottom line and border colors in the focused state.
/// @param {Color} $interim-bottom-line-color [null] - The bottom line and border colors during the to-focused transition.
/// @param {Color} $disabled-bottom-line-color [null] - The bottom line and border colors in the disabled state.
/// @param {Color} $border-color [null] - The border color for input groups of type border and fluent.
/// @param {Color} $hover-border-color [null] - The hover input border for input groups of type border and fluent.
Expand Down Expand Up @@ -86,7 +85,6 @@
$idle-bottom-line-color: null,
$hover-bottom-line-color: null,
$focused-bottom-line-color: null,
$interim-bottom-line-color: null,
$disabled-bottom-line-color: null,

$border-color: null,
Expand Down Expand Up @@ -234,7 +232,6 @@
idle-bottom-line-color: $idle-bottom-line-color,
hover-bottom-line-color: $hover-bottom-line-color,
focused-bottom-line-color: $focused-bottom-line-color,
interim-bottom-line-color: $interim-bottom-line-color,
disabled-bottom-line-color: $disabled-bottom-line-color,
border-color: $border-color,
hover-border-color: $hover-border-color,
Expand Down
Loading