-
Notifications
You must be signed in to change notification settings - Fork 228
DOC: Complete list of aliases #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
{aliases} | ||
- G = outgrid | ||
- Sa = above | ||
- Sb = below | ||
- Si = between | ||
- Sr = replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The {aliases}
placeholder will be expanded to something like:
.. hlist::
:columns: 3
- R = region
- J = projection
Currently, the solution is to add the missing aliases below the {aliases}
placeholder. Does it look bad? Perhaps we should maintain the full list of aliases manually, i.e., remove the {aliases}
placeholder and manually add all aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should maintain the full list of aliases manually, i.e., remove the
{aliases}
placeholder and manually add all aliases.
See the changes in grdfill.py
for another style.
Please see the changes in 🚀 for the style in |
Ping @GenericMappingTools/pygmt-maintainers again for comments on this since some PRs are waiting for it. I prefer the
|
Addressing the 2nd point raised in issue #3881.
As we break complex options into multiple parameters, the current alias system no longer works, and the
{aliases}
placeholder in docstrings can't list these parameters anymore.In issue #3881, I proposed to remove the list of aliases if the documentation on the PyGMT side is complete, but it seems people are against it, and the reasons sounds fair to me.
So, instead of removing the list of aliases, I guess we need to manually add the missing aliases back to the list.
Preview: