Skip to content

Tests for LinkedIn\AccessToken #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2017
Merged

Tests for LinkedIn\AccessToken #2

merged 2 commits into from
Aug 25, 2017

Conversation

iamsalnikov
Copy link
Contributor

I covered with testsLinkedIn\AccessToken

I did not create tests for:

  1. Getters and setters for tokens
  2. Getters and setters for expiresAt/expiresIn. I don't know how I can mock function time() without a lot of troubles. I can not guarantee stability of tests without mocking time()

I will be grateful for review and critics :) ... and for ideas about mocking time()

If I have to create tests for token's getters/setters - please, tell me and I will cover it.

@zoonman zoonman merged commit 70cec3e into zoonman:master Aug 25, 2017
@iamsalnikov iamsalnikov deleted the test_access_token branch August 25, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoonman zoonman zoonman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamsalnikov @zoonman