Skip to content

Add tests for Junit 5 and fix PreparedDbExtension instance(non-static) lifecycle. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

jameshilliard
Copy link

@jameshilliard jameshilliard commented Sep 23, 2020

This is mostly just a port of the Junit 4 tests to Junit 5.

@jameshilliard jameshilliard force-pushed the junit-jupiter branch 3 times, most recently from 4dfe007 to 90fc71b Compare September 23, 2020 23:55
Copy link
Collaborator

@tomix26 tomix26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Just improve the configuration of the extension, and then it will be ready to merge 👍

Copy link
Collaborator

@tomix26 tomix26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've improved the StaticDbExtension test a bit and renamed it to DatabaseLifecycleTest, otherwise, it looks good. Great job, thanks a lot 👍

@tomix26 tomix26 merged commit e5dfe4b into zonkyio:master Nov 3, 2020
@jameshilliard jameshilliard deleted the junit-jupiter branch November 17, 2020 18:56
@tomix26 tomix26 added this to the 1.2.9 milestone Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants