Skip to content

More open rspec and activesupport dep versions #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rspec_api_documentation.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ $:.unshift lib unless $:.include?(lib)

Gem::Specification.new do |s|
s.name = "rspec_api_documentation"
s.version = "4.8.0"
s.version = "4.8.1"
s.platform = Gem::Platform::RUBY
s.authors = ["Chris Cahoon", "Sam Goldman", "Eric Oestrich"]
s.email = ["chris@smartlogicsolutions.com", "sam@smartlogicsolutions.com", "eric@smartlogicsolutions.com"]
Expand All @@ -14,9 +14,9 @@ Gem::Specification.new do |s|

s.required_rubygems_version = ">= 1.3.6"

s.add_runtime_dependency "rspec", "~> 3.0", ">= 3.0.0"
s.add_runtime_dependency "activesupport", ">= 3.0.0"
s.add_runtime_dependency "mustache", "~> 1.0", ">= 0.99.4"
s.add_runtime_dependency "rspec", "~> 3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is the same as the other rspec line. We were just specifically saying "anything above 3.0.0 is fine" which I added to make the gem builder happy.

s.add_runtime_dependency "activesupport", "~> 3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restricts the activesupport dependency. We were incredibly open before.

s.add_runtime_dependency "mustache", "~> 1.0", ">= 0.99.4"

s.add_development_dependency "bundler", "~> 1.0"
s.add_development_dependency "fakefs", "~> 0.4"
Expand Down