fix more tests for markup/markdown/katex tests #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Oct 5, 2022
| @@ -88,7 +88,9 @@ func ExtractMetadataBytes(contents []byte, out interface{}) ([]byte, error) { | |||
| line := contents[start:end] | |||
| if isYAMLSeparator(line) { | |||
| front = contents[frontMatterStart:start] | |||
| body = contents[end+1:] | |||
| if end+1 < len(contents) { | |||
There was a problem hiding this comment.
This isn't actually necessary.
End is guaranteed to be at most the last character of the slice and slice[len(slice):] never overflows
There was a problem hiding this comment.
End is guaranteed to be at most the last character of the slice and slice[len(slice):] never overflows
Yup, however:
suppose len(contents) == 1, end=len(contents)=1 (line 83), then contents[end+1:] is contents[2:], which causes out-of-bound error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.Exit(m.Run())tomarkup/html_test.goand fix the test inTestRender_emojimarkup/markdown/meta.gomarkup/markdown/meta_test.goutil.Dedent, YAML can accept global indention.