Skip to content

variants: arduino_nano_33_iot: describe unit address in hex #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

variants: arduino_nano_33_iot: describe unit address in hex #63

merged 1 commit into from
Oct 18, 2022

Conversation

soburi
Copy link
Member

@soburi soburi commented Oct 13, 2022

Fix this warnings

unit address and first address in 'reg' (0xa) don't match for /soc/adc@42004000/channel@10
unit address and first address in 'reg' (0xb) don't match for /soc/adc@42004000/channel@11
unit address and first address in 'reg' (0x12) don't match for /soc/adc@42004000/channel@18
unit address and first address in 'reg' (0x13) don't match for /soc/adc@42004000/channel@19

unit address and first address in 'reg' (0x6a) don't match for /soc/sercom@42001800/atecc608a@15

may be problem in boards/arm/arduino_nano_33_iot/arduino_nano_33_iot.dts

@soburi soburi mentioned this pull request Oct 13, 2022
Merged
@soburi
variants: describe unit address in hex
3498b75 
Fix unit-address and reg value to be described in hex

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
DhruvaG2000
DhruvaG2000 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked these changes on top of PR#60 , and the warnings do go away.
hence, LGTM.

@DhruvaG2000
Copy link
Collaborator

Please rebase #60 now that this PR is being merged in upstream main.
Thanks!

@DhruvaG2000 DhruvaG2000 merged commit 5c305c6 into zephyrproject-rtos:main Oct 18, 2022
@soburi soburi deleted the fix-unit-address branch October 18, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhruvaG2000 DhruvaG2000 DhruvaG2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soburi @DhruvaG2000