zephyrCommon: Add Print::write(const uint8_t*, size_t) default implementation

[soburi]

When compile with enabling CONFIG_DEBUG option,
the Print::write virtual function failed to link.

This implementation is usually not used.
Because the override implementation that implements by the subclass will be used.

Signed-off-by: TOKITA Hiroshi tokita.hiroshi@fujitsu.com

[DhruvaG2000]

In my opinion this should go into cores/arduino/zephyrSerial.cpp.
At the moment we are not really very well integrating the Arduino Core API in serial aspect, so perhaps you may want to drop the arduino::Print and use arduino::ZephyrSerial:: and also add the write in respective header file where we write the func prototypes.

[soburi]

@DhruvaG2000

In my opinion this should go into cores/arduino/zephyrSerial.cpp.

The Print class is also used by (TCP) Client class, UDP class, and also user-defined classes via the Stream class.
I think it should not be placed in zephyrSerial because it has no relation to the Serial class.

I rewrited it to splitting into the new file named 'zephyrPrint.cpp'.
Please review it.

[DhruvaG2000]

Okay, so this seems to be taken from here

size_t Print::write(const uint8_t *buffer, size_t size)
{
  size_t n = 0;
  while (size--) {
    if (write(*buffer++)) n++;
    else break;
  }
  return n;
}

but with for loop instead.

[soburi]

One confirmation.
Is it okayto copy from GPL?

[DhruvaG2000]

Not really, I think this way that you have done is also okay.

[DhruvaG2000]

Seems like this file can in future have a similar structure to original Print.cpp
Perhaps we can even consider migrating ZephyrSerial entirely to use this file itself.
@szczys and @alvarowolfx I would love to hear your thoughts on this

[DhruvaG2000]

Looks like a good starting point to me.
Built locally, LGTM.

[DhruvaG2000]

Been too long since approved, I do not see any nacks, hence merging.