Skip to content

variants: arduino_nano_33_iot: Fix 'i2c0' fail to resolve #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

soburi
Copy link
Member

@soburi soburi commented Sep 23, 2022

Use arduino_nano_i2c instead of i2c0.

Signed-off-by: TOKITA Hiroshi tokita.hiroshi@fujitsu.com

@DhruvaG2000
Copy link
Collaborator

@soburi does this PR solve #50 ?
If so then kindly mention "close #50" in the commit or PR description

@DhruvaG2000 DhruvaG2000 self-requested a review September 23, 2022 15:49
@soburi
Copy link
Member Author

soburi commented Sep 23, 2022

@soburi does this PR solve #50 ? If so then kindly mention "close #50" in the commit or PR description

Oh! I missed #50 issue.
Add mention to #50.

Thank you notify to me.

@soburi soburi force-pushed the fix_nano33iot_i2c_unresolved branch from 2d4a7fb to d185c2c Compare September 24, 2022 05:40
@DhruvaG2000 DhruvaG2000 linked an issue Sep 24, 2022 that may be closed by this pull request
Use arduino_nano_i2c instead of i2c0.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>
@soburi soburi force-pushed the fix_nano33iot_i2c_unresolved branch from d185c2c to b05e43b Compare September 24, 2022 22:02
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build locally, however I don't have hardware to test.
Code LGTM.

@DhruvaG2000 DhruvaG2000 merged commit a896076 into zephyrproject-rtos:main Sep 25, 2022
@soburi soburi deleted the fix_nano33iot_i2c_unresolved branch September 25, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails for arduino nano 33 iot
2 participants