Skip to content

variants: bunch all includes in common file #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

DhruvaG2000
Copy link
Collaborator

Also fix #47

Signed-off-by: Dhruva Gole goledhruva@gmail.com

@DhruvaG2000 DhruvaG2000 marked this pull request as draft September 17, 2022 16:16
@DhruvaG2000 DhruvaG2000 force-pushed the fix/include-build-warns branch 2 times, most recently from fd7394e to ea681ae Compare September 17, 2022 16:27
@DhruvaG2000 DhruvaG2000 marked this pull request as ready for review September 17, 2022 16:31
Copy link
Collaborator

@szczys szczys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I would suggest that you add to your commit message to indicate this matches the Zephyr naming convention change from zephyr.h to kernel.h

- zephyr.h is already deprecated, hence using kernel.h instead of it.
- fix #47
- affects cores/ and variants/ dirs

Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
@DhruvaG2000 DhruvaG2000 force-pushed the fix/include-build-warns branch from ea681ae to 3a5430a Compare September 22, 2022 15:37
@DhruvaG2000 DhruvaG2000 merged commit 5a76d45 into main Sep 22, 2022
@DhruvaG2000 DhruvaG2000 deleted the fix/include-build-warns branch November 19, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zephyr build warnings: zephyr.h is deprecated, include <zephyr/kernel.h> instead
2 participants