-
Notifications
You must be signed in to change notification settings - Fork 33
variants: add support for arduino_mkrzero #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@szczys can you help with inbuilt LED please? |
However when I add <22 0 &portb 8 0>; /* BUILTIN LED */ It doesn't work when I do led0 = <&arduino_mkr_header 22 0>; in my overlay Am I missing something here? |
I am also confused. I looked at the schematic, the port and pin look correct but the flag should be However, when you look at the DTS file in Zephyr it's a very different story. They're using pin 17 for the LED: Maybe give that a try and see if it works? I suspect Arduino and Zephyr handle the pin mux differently which results in different naming scheme for the pins, but I'm only guessing. |
I should point out here, that the link you sent is for the arduino_zero and
not the arduino_mkr_zero. There are changes in those 2 boards although I
guess the chip remains the same. I am in talks with @galak on the discord
channel, let's see if we can figure something out on this later perhaps,
for now we should probably not include either the inbuilt LED and advise
user to use an external one?
…On Tue, Aug 23, 2022 at 11:56 PM Mike Szczys ***@***.***> wrote:
@DhruvaG2000 <https://github.com/DhruvaG2000>
I tried d22_gpios = < &portb 8 GPIO_ACTIVE_LOW>; but did not work
I am also confused. I looked at the schematic, the port and pin look
correct but the flag should be GPIO_ACTIVE_HIGH.
[image: image]
<https://user-images.githubusercontent.com/367685/186235272-250b92b8-8397-4d6f-8fb5-3b4cb51d23a7.png>
However, when you look at the DTS file in Zephyr it's a very different
story. They're using pin 17 for the LED:
https://github.com/zephyrproject-rtos/zephyr/blob/e7591615724894a2319ea2c09d7eb21b4263fbf0/boards/arm/arduino_zero/arduino_zero.dts#L32-L35
Maybe give that a try and see if it works? I suspect Arduino and Zephyr
handle the pin mux differently which results in different naming scheme for
the pins, but I'm only guessing.
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2S3QGOZTCNYZN72NUMWVTV2UJVLANCNFSM57CTEQ4A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
89de89c
to
7fec7bc
Compare
a168e1d
to
930c6bd
Compare
Add support for the arduino mkr zero board. - Add the LED builtin in arduino mkrzero - Add sercom as i2c because that's how it is described in arduino_mkrzero.dts: pinctrl-0 = <&sercom0_i2c_default>; Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
930c6bd
to
4a856b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't have a board to test this on, but I was able to build samples.
Adds support for the arduino mkr zero board. Tested with LED_Blink sample.
I am not sure about the inbuilt LED pin number though, hence this pinmap just uses D7 for
demo purposes
Signed-off-by: Dhruva Gole goledhruva@gmail.com