Fix/samples/cmakelists #31
Conversation
There was a problem hiding this comment.
Wow! This is great work. I'm really interested to hear how you got the $ZEPHYR_BASE part of this to work since I don't see it set in my ENV.
Compilation works worked for me after I tweaked directory names, I suggest the following changes should be included in this PR:
- The directories in the variants folder should be renamed to all lower-case
- CMakeLists.c files in all samples should be changed to match changes made in this PR (hello-arduino)
This is a giant improvement, nice job!
|
Is this ready for review? If so, let's take it out of draft! |
I am not able to rename all the folder names for some reason, just some issue with windows or something I guess... Other than that all the CMake changes are done, only renaming is left |
|
Have to make all the folder names from caps to small case |
DhruvaG2000
force-pushed
the
fix/samples/Cmakelists
branch
4 times, most recently
from
31022f0 to
efe2208
Compare
Cmakelists was unable to previously find the overlay path that was board specific This path had to be hardcoded into each sample for each different board. Now, with the help of BOARD variable we can automatically find the overlay path using cmake.
adapt to the new changes in cmakelists that uses the BOARD variable that expands to the small case of the board in use. Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
DhruvaG2000
force-pushed
the
fix/samples/Cmakelists
branch
from
efe2208 to
629c690
Compare
|
Merging to dev since I have @szczys approval! |
No description provided.