Skip to content

Support for php8 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Support for php8 #93

merged 3 commits into from
Sep 30, 2020

Conversation

dreamsxin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@mruz
Copy link

mruz commented Sep 28, 2020

Could you also add 8.0 to:
https://github.com/phalcon/php-zephir-parser/blob/1e765d5c28c6cff4c442f90030f013620808fe62/.github/workflows/main.yml#L29
and update readme:

Supported PHP versions: 7.0, 7.1, 7.2, 7.3 and 7.4.

@mruz
Copy link

mruz commented Sep 30, 2020

Unable to obtain PHP version string using pattern 'php-(7.2.\d+)-src'

AppVeyor build failed because of the version name php-7.2.33-1-src.zip
https://windows.php.net/downloads/releases/

mruz added a commit to mruz/php-appveyor that referenced this pull request Sep 30, 2020
@niden niden merged commit 479fd30 into zephir-lang:development Sep 30, 2020
@niden
Copy link
Contributor

niden commented Sep 30, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants