Skip to content

Ci builds fixes #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Dec 6, 2021
Merged

Ci builds fixes #135

merged 32 commits into from
Dec 6, 2021

Conversation

AlexNDRmac
Copy link
Member

@AlexNDRmac AlexNDRmac commented Dec 5, 2021

Hello!

Small description of change:

  • Reworked build workflow
  • Added PECL package generation
  • Added missed files (VERSION, LICENSE, CREDITS, NO_WARRANTY, CHANGELOG.md) into build artifacts
  • Added missed VERSION file into PECL package

Thanks

@AlexNDRmac AlexNDRmac requested a review from Jeckerson December 5, 2021 21:00
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #135 (0938b1f) into development (f242ab9) will increase coverage by 2.83%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #135      +/-   ##
===============================================
+ Coverage        75.79%   78.63%   +2.83%     
===============================================
  Files                5        5              
  Lines             2954     5101    +2147     
===============================================
+ Hits              2239     4011    +1772     
- Misses             715     1090     +375     
Flag Coverage Δ
Linux 76.32% <ø> (?)
macOS 87.44% <ø> (?)
unittests 78.63% <ø> (+2.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
parser/scanner.re 85.63% <0.00%> (-12.65%) ⬇️
zephir_parser.c 91.66% <0.00%> (-5.21%) ⬇️
parser/parser.h 88.98% <0.00%> (-0.54%) ⬇️
parser/base.c 93.65% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f242ab9...0938b1f. Read the comment docs.

@AlexNDRmac AlexNDRmac merged commit d4960c3 into development Dec 6, 2021
@AlexNDRmac AlexNDRmac deleted the ci-builds-fixes branch December 6, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing and bad files in archive Unify windows release assets with PECL ones
2 participants