Skip to content

#125 - Rename PHP_ZEPHIR_PARSER_NAME to zephir_parser #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/win-ci-tools.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function EnableExtension {

Copy-Item -Path "${env:RELEASE_DLL_PATH}" -Destination "${env:PHPROOT}\ext\"

Enable-PhpExtension -Extension 'Zephir Parser' -Path "${env:PHPROOT}"
Enable-PhpExtension -Extension zephir_parser -Path "${env:PHPROOT}"
}

function PrepareReleasePackage {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ jobs:
- name: Run Tests
if: matrix.arch == 'x64'
run: |
& ${env:TEST_PHP_EXECUTABLE} --ri 'Zephir Parser'
& ${env:TEST_PHP_EXECUTABLE} --ri zephir_parser
& ${env:TEST_PHP_EXECUTABLE} run-tests.php

- name: Prepare Release Package
Expand Down Expand Up @@ -321,7 +321,7 @@ jobs:

- name: Run Tests
run: |
php -d extension=./modules/zephir_parser.so --ri 'Zephir Parser'
php -d extension=./modules/zephir_parser.so --ri zephir_parser
make test NO_INTERACTION=1 REPORT_EXIT_STATUS=1

- name: Print failures
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
- Renamed extension name from `Zephir Parser` to `zephir_parser` [#125](https://github.com/phalcon/php-zephir-parser/issues/125)

## [1.4.0] - 2021-09-18
### Added
Expand Down
6 changes: 3 additions & 3 deletions tests/base/extension_info.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function contains($input, $expected) {
: 'not contains';
}

$version = phpversion('Zephir Parser');
$version = phpversion('zephir_parser');
$actual = trim(file_get_contents(__DIR__ . '/../../VERSION'));

$compare = $version === $actual;
Expand All @@ -23,7 +23,7 @@ $info = trim(ob_get_clean());

echo contains($info, 'Zephir Parser').PHP_EOL;
echo contains($info, 'The Zephir Parser delivered as a C extension for the PHP language.').PHP_EOL;
echo contains($info, 'Zephir Parser => enabled').PHP_EOL;
echo contains($info, 'zephir_parser => enabled').PHP_EOL;
echo contains($info, 'Author => Zephir Team and contributors').PHP_EOL;
echo contains($info, 'Version =>').PHP_EOL;
echo contains($info, 'Build Date =>').PHP_EOL;
Expand All @@ -32,7 +32,7 @@ echo contains($info, 'Build Date =>').PHP_EOL;
bool(true)
Zephir Parser
The Zephir Parser delivered as a C extension for the PHP language.
Zephir Parser => enabled
zephir_parser => enabled
Author => Zephir Team and contributors
Version =>
Build Date =>
2 changes: 1 addition & 1 deletion tests/skipif.inc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php if (!extension_loaded("Zephir Parser")) print "skip The zephir_parser extension is not loaded"; ?>
<?php if (!extension_loaded("zephir_parser")) print "skip The zephir_parser extension is not loaded"; ?>
2 changes: 1 addition & 1 deletion zephir_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
extern zend_module_entry zephir_parser_module_entry;
#define phpext_zephir_parser_ptr &zephir_parser_module_entry

#define PHP_ZEPHIR_PARSER_NAME "Zephir Parser"
#define PHP_ZEPHIR_PARSER_NAME "zephir_parser"
#define PHP_ZEPHIR_PARSER_VERSION "1.4.0"
#define PHP_ZEPHIR_PARSER_AUTHOR "Zephir Team and contributors"
#define PHP_ZEPHIR_PARSER_DESCRIPTION "The Zephir Parser delivered as a C extension for the PHP language."
Expand Down