Skip to content

#110 - Windows builds #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 143 commits into from
Sep 7, 2021
Merged

#110 - Windows builds #111

merged 143 commits into from
Sep 7, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Aug 20, 2021

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@Jeckerson Jeckerson marked this pull request as draft August 20, 2021 20:20
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #111 (2590e36) into development (f51e5f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #111   +/-   ##
============================================
  Coverage        75.18%   75.18%           
============================================
  Files                5        5           
  Lines             2909     2909           
============================================
  Hits              2187     2187           
  Misses             722      722           
Flag Coverage Δ
unittests 75.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51e5f3...2590e36. Read the comment docs.

@Jeckerson Jeckerson marked this pull request as ready for review September 7, 2021 11:48
@Jeckerson Jeckerson requested a review from AlexNDRmac September 7, 2021 11:48
@Jeckerson Jeckerson marked this pull request as draft September 7, 2021 11:49
@Jeckerson Jeckerson marked this pull request as ready for review September 7, 2021 11:58
@Jeckerson Jeckerson merged commit a8af67f into development Sep 7, 2021
@Jeckerson Jeckerson deleted the #110-win-builds branch September 7, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants