Added imagePullSecrets option for spilo pod #1308
Open
+107
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dervoeti
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
Since this PR is almost 3 years old, I don't think it can be reviewed / merged as a lot has probably changed since then. Are the maintainers even open for such a change? I would be open to help but I don't want to invest time in a feature that the maintainers are not interested in. |
|
Hi Team, I really need this feature. Can maintainers help to resolve the conflict and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to deploy my own spilo image in a cluster, the image is hosted in a private registry. Therefore i added an option to specify imagePullSecrets for the pods running spilo. It can be specified in the operator configuration as well as in the cluster manifest (in CRDs and/or ConfigMap).
I have built the operator image and ran it in my cluster, it works fine there (tested with and without imagePullSecrets). The change should be backwards compatible. A bit of documentation and examples are added as well.