Skip to content

Refactoring and tests #5

Open
Open
@mjablecnik

Description

@mjablecnik

Hello @xnbox I found your DeebfakeHTTP project here and it looks very nice 👍
You created nice tool with good documentation and probably I will be use it ;-)

But when I look into your code so I can really recommend you to read Clean Code book by Robert C. Martin.
Because I found that you need it.

Then I really recommend you to go through your projects and made refactor because in DeepfakeHttpServlet you have very big doDbRequest function which can be splited into more smaller functions for better readability.
I tried understand it for future contribution but it is very hard to read and understand for me..

The same you can make also in your other projects for example BrowserWindow.java intommybox project you have really big launch function or createMenu function..

Also you should create some tests for ensure that after your refactor works everything right.

Without this changes will be very hard for other developers like me to understand your code and make some changes and PRs in the future..

I hope it will be improved and your project will be successful in the Open Source world. ;-)

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions