Ability to define custom test_runner for Django test runner #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er` extensibility
Move test_runner kwargs generation into separate method, like in django 1.11+ (still working in prior versions) Use `test_runner` attribute instead of hardcoded `xmlrunner.XMLTestRunner`
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 99.28% 99.29% +0.01%
==========================================
Files 17 17
Lines 1117 1136 +19
==========================================
+ Hits 1109 1128 +19
Misses 8 8
Continue to review full report at Codecov.
|
dnozay
requested changes
May 17, 2017
xmlrunner/extra/djangotestrunner.py
Outdated
|
|
||
| if single_file is None: # output is a stream | ||
| output = output_dir | ||
| else: # output is a folder |
There was a problem hiding this comment.
there is already a if single_file is not None
|
|
||
| def run_suite(self, suite, **kwargs): | ||
| dummy = kwargs # unused |
There was a problem hiding this comment.
this was a useful (somewhat) comment.
xmlrunner/extra/djangotestrunner.py
Outdated
|
|
||
| def run_suite(self, suite, **kwargs): | ||
| kwargs = self.get_test_runner_kwargs() | ||
| runner = self.test_runner(**kwargs) |
There was a problem hiding this comment.
note: i don't like naming kwargs as it is redefined locally.
|
@dnozay thanks for comments. I hope it's better now ) |
dnozay
approved these changes
Jun 29, 2017
|
@dnozay I would love to have this for a project I am working on. Any chance we can get a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlrunner.XMLTestRunnerwas hardcoded intoxmlrunner.extra.djangotestrunner.XMLTestRunner. Now it's overridable attribute ofxmlrunner.extra.djangotestrunner.XMLTestRunnerxmlrunner.XMLTestRunneris now generated in separateget_test_runner_kwargsmethod. It's made as in Django 1.11 but will work in Django 1.8 as well. Just follow naming convention. This was done mostly for code cleanup and separation.mocklibrary was added in tox dependencies, hope it's ok.