This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Facebook 1.0.13 #157
Merged
Facebook 1.0.13 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glob support has been added in source-map-explorer@1.4+
This allows you to set REACT_EDITOR to 'vim --remote', so the file can be opened in an already running vim process. When using vim without remote, it works in the same way as before. When launching vim without --remote, the order of the line and path arguments doesn't matter. However, when using --remote the line argument has to precede the path. This happens to be the same as joe and emacs uses, so the vim cases were just moved there. I haven't tested this with mvim, but the documentation says the same as the vim documentation, so I assume it works the same.
PyCharm has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html Tested with PyCharm Pro 2017.1.4 on MacOS 10.12
Jest's default value for this option is ["js", "json", "jsx", "node"]. CRA's current value is ["web.js", "js", "json", "web.jsx", "jsx"], which is missing one of default ones: "node". This change fixes that. This "node" extension is used in packages that use native code.
* Update eslint-loader 1.7.1 -> 1.9.0 * Add eslintPath option * Update eslint 3.19.0 -> 4.1.1 * Update peer dependencies * Move eslintPath config to outside @remove-on-eject
* Use oneOf to resolve correct loader * Add html and json fallthrough again * Use oneOf to resolve correct loader in dev * Document file-loaders `js` exclusion * Remove `jsx` from exclusion in prod config
Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to #2636
* dont prompt if serve is already installed * change name for readability * Pin the version
* Docs for react-router v4 basename feature Fix facebook/create-react-app#2593 * Update README.md * Update README.md * Update README.md * Update README.md
Closes #2713
* change error wording and list conflicting files when initializing app * update code * Update createReactApp.js
* Add source-map-loader to support source maps of dependencies * merge with latest develop * add ModuleConcatenationPlugin * revert source-map-loader * bump to 3.1 and update dev-server * rebase to master * rebase again * bump webpack * remove ModuleConcatenationPlugin, downgraded react packages, bump etwp * ETWP rc1 only for testing * bump ETWP and webpack 3 * bump WP3 * revert to 3.2.0 * bump sw-precache-webpack-plugin * bump back to 3.3.0 * bump dev-server and manifest
* bump wp3 * try bump babel-loader
The create-react-app need node >= 6, and node version 6 support a lot of ES6, and let's switch using '+' to concat string with template string.
* Remove note about webpackHotDevClient being webpack 1.0 only It must work in webpack 2 since create-react-app is still using it and is using webpack 2 now. It would be great if you could add some kind of note about how it differs from the default webpack hot reloaders. * Update README.md * Update README.md
* Fix parsing HTML/JSX tags to real elements * Use `html-entities` to escape instead of pure `replace()` * Remove unnecessary HTML entity replacing
Since yarn.lock shouldn't be added to the repo, nor excluded via .gitignore, lets take advantage of lint-staged to remove any staged yarn.lock files before they can even be committed.
* format UglifyJs error * move formatBuildError to react-dev-utils * fix readme * use regex for plucking the path from stack * make path human readable and fallback to show error if regex not matched * rename to printBuildError and add link to the docs * fix link indentation * improve readibility + shorten link
* Re-enable flowtype warning * Update eslint-plugin-flowtype dependency
* Allow importing package.json * Remove package.json import from App.js template * fix importing package.json * Rename variable to reflect path is relative to root * Check for both package & package.json in ModuleScopePlugin * Use regex to check relative path to package.json * Strictly enforce package.json extension on scope plugin * Add allowedPaths to ModuleScopePlugin ctor and use it to allow app package.json * Remove package.json import from App.js template * Add package.json to react-scripts/template, show package version and name in the template * Remove import package.json from template * Remove template/package.json and its references in code * Update ModuleScopePlugin.js * Update README.md
* bump wp3 * try bump babel-loader * bump 3.4.1
* Fix the order of arguments in spawned child proc * Update react-scripts.js * Remove a comma * Update react-scripts.js
The service was rebranded to xervo.io and was completely shut down in April 2017
* Fix docs for `printFileSizesAfterBuild` * Add optionals parameters for `printFileSizesAfterBuild`
* Debugging in WebStorm * Fixed formatting for shortcuts * Added note about default URL
* Convert react-error-overlay to React * Update compile-time error overlay to use react-error-overlay components * Refactor react-error-overlay components to container and presentational components. * Make the compile-time error overlay a part of react-error-overlay package. * Use react-error-overlay as dependency in react-dev-utils to show compile-time errors. * Run Prettier * Move the function name fix into StackFrame itself * Fix clicking on source code snippet to open the code in editor * Use exact objects + minor style tweak * Don't linkify frames that don't exist on the disk * Fix lint * Consolidate iframe rendering logic * Remove circular dependency between react-dev-utils and react-error-overlay * Fix lint * Fix decoupling of react-dev-utils and react-error-overlay by moving middleware * Deduplicate identical errors
…pts (#2991)
* update babel-runtime dependency in react-error-overlay and react-scripts
`babel-runtime@6.23.0` have a dependency on `regenerator-runtime@0.10.5`
`babel-runtime@6.26.0` on `regenerator-runtime@0.11.0`
> npm ls regenerator-runtime
```
└─┬ react-scripts@1.0.11
├─┬ babel-core@6.25.0
│ └─┬ babel-runtime@6.26.0
│ └── regenerator-runtime@0.11.0
├─┬ babel-eslint@7.2.3
│ └─┬ babel-traverse@6.26.0
│ └─┬ babel-runtime@6.26.0
│ └── regenerator-runtime@0.11.0
├─┬ babel-runtime@6.23.0
│ └── regenerator-runtime@0.10.5
└─┬ react-error-overlay@1.0.10
└─┬ babel-runtime@6.23.0
└── regenerator-runtime@0.10.5
```
* fix requested changes
…before webpack client (#3046)
* Make error overlay file configurable * Add fallback filename
|
If the Travis build needs a workaround it should work by pulling in facebook/create-react-app@e8b58ed , left it out since it wasn't part of the 1.0.13 tag |
|
@wmonk it is probably very scary for you to review "merging upstream" PRs due to huge amount of stuff you need to dig into. Your I am really awaiting upstream since @JohnNilsson 🥇 for helping to keep up with upstream! |
|
Hi all, I will look to get this out over the weekend. Thanks for your patience! |
|
@JohnNilsson I will be more confident if CI is passing. Could you pull in the necessary commits, and I will release a backdated commit, to match |
wmonk
suggested changes
Sep 15, 2017
packages/react-scripts/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "react-scripts-ts", | |||
| "version": "2.6.0", | |||
| "version": "1.0.12", | |||
There was a problem hiding this comment.
Please change version back to 2.6.0
wmonk
approved these changes
Sep 15, 2017
|
Woohoo 🎉 thanks @JohnNilsson really appreciated 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the facebook-1.0.11 PR from before (including source-map-loader). Pretty straight forward merge resolutions.
As before, tested insofar that "yarn build" and "yarn start" seem to work.
(I also got around my previous issue with minification by using
"downlevelIteration": truei tsconfig. So perhaps no need for babel after all)