Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Mixed dependencies #142

Closed
Closed
@swengorschewski

Description

@swengorschewski

Is this a bug report?

Yes. Typings are installed as dependencies.

Environment

  1. npm ls react-scripts-ts: 2.6.0
  2. node -v: 8.3.0
  3. npm -v: 5.3.0
  4. yarn --version: 0.27.5

Steps to Reproduce

  1. create-react-app my-app --scripts-version=react-scripts-ts

Expected Behavior

{
  ...
  "dependencies": {
    "react": "^15.6.1",
    "react-dom": "^15.6.1",
    "react-scripts-ts": "2.6.0"
  },
  "devDependencies": {
    "@types/jest": "^20.0.7",
    "@types/node": "^8.0.22",
    "@types/react": "^16.0.2",
    "@types/react-dom": "^15.5.3"
  }
  ...
}

Actual Behavior

{
  ...
  "dependencies": {
    "@types/jest": "^20.0.7",
    "@types/node": "^8.0.22",
    "@types/react": "^16.0.2",
    "@types/react-dom": "^15.5.3",
    "react": "^15.6.1",
    "react-dom": "^15.6.1",
    "react-scripts-ts": "2.6.0"
  },
  ...
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions