This repository was archived by the owner on Mar 16, 2019. It is now read-only.
Fix issue where invoke would be called more than once during cp call #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will this version (0.11.0) with the fix be available for usage at master? |
fiznool
added a commit
to studiozeffa/rn-fetch-blob
that referenced
this pull request
Aug 15, 2018
Fixes a case where `callback` was called twice when something went wrong in the `cp` operation, leading to a `java.lang.RuntimeException: Illegal callback invocation from native module. This callback type only permits a single invocation from native code.` This is the same fix [as seen in the original repo](wkh237#408).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code raises a
java.lang.RuntimeException: Illegal callback invocation from native module. This callback type only permits a single invocation from native code.whencperrors but successfully closes its streams.In the case where there was an exception during copy,
cpwould call invoke twice -- once for the exception and then again in thefinallyblock when the streams are closed.