This repository was archived by the owner on Mar 16, 2019. It is now read-only.
making it so there are more options for notifications visibility #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, all android download notifications always show up in the task bar of the OS, because the enum VISIBILITY_VISIBLE_NOTIFY_COMPLETED is used. In order to allow the developer to not show notifications if they desire, I have added the ability to add a notificationsEnum property to the addAndroidDownloads writable map that can be filled in with,
0 - VISIBILITY_VISIBLE
1 - VISIBILITY_VISIBLE_NOTIFY_COMPLETED
2 - VISIBILITY_HIDDEN
3 - VISIBILITY_VISIBLE_NOTIFY_ONLY_COMPLETION
If no notificationsEnum property is supplied to addAndroidDownloads, the default will be used.
https://developer.android.com/reference/android/app/DownloadManager.Request.html#VISIBILITY_VISIBLE_NOTIFY_COMPLETED