This repository was archived by the owner on Mar 16, 2019. It is now read-only.
Fix Android file saving bug #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you ! |
zombierabbit
pushed a commit
to zombierabbit/react-native-fetch-blob
that referenced
this pull request
Feb 12, 2019
Add typescript type defenitions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a file would not be saved after specifying the
pathwhen fetching a file (as described here) on Android if the directories above the file at the specifiedpathdo not exist.The file save was failing silently as the exception was swallowed by this catch block. I haven't added anything here but I guess that would be good to change at some point.
To fix the bug, I just create all missing directories above the file at the specified path if they don't exist.
It sounds like this is what was causing the problem in #133 too.