add friendship & scheduler bot #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangaszaq
approved these changes
May 31, 2020
| self.auto_reply_comment = "Automatic Reply: I cannot read your message because I'm busy now, will talk to you when I get back." | ||
|
|
||
| async def on_friendship(self, friendship: Friendship): | ||
| administrator = bot.Contact.load('admin-id') |
There was a problem hiding this comment.
Can we define a admin-id as a global variable? Then it is easier to understand.
There was a problem hiding this comment.
local variable or global variable pattern depends on the developers. Even admin-id from database is all supported. This is the only contact-id string here. I believe it's easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create friendship bot and scheduler bot refer to wechaty-getting-started.