-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs(general): Revise "imposter syndrome" language #5016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(general): Revise "imposter syndrome" language #5016
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/2unuXLffaiBAVsf9xKsZbom4UAFc |
While there are typically more edits and files than I'd normally include in a PR, I hope the small changes make for a quick review. Happy to consider any language changes you don't agree with, and welcome PR review comments. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Please sign the CLA here https://cla.js.foundation/webpack/webpack.js.org?pullRequest=5016.
Co-authored-by: Sam Chen <chenxsan@gmail.com>
Co-authored-by: Sam Chen <chenxsan@gmail.com>
@chenxsan update; ✅ CLA Signed I think once we sync up on that last question, this should be good to go. Thanks for being open to the PR! |
Since we'd changed the header text.
@chenxsan I've added the redirect as requested. I think at this point all feedback items have been addressed. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Resolves #5015.