Skip to content

docs(general): Revise "imposter syndrome" language #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SeanKilleen
Copy link
Contributor

@SeanKilleen SeanKilleen commented May 25, 2021

Resolves #5015.

@vercel
Copy link

vercel bot commented May 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/2unuXLffaiBAVsf9xKsZbom4UAFc
✅ Preview: https://webpack-js-org-git-fork-seankilleen-5015revise-imposter-5923a6.vercel.app

@SeanKilleen
Copy link
Contributor Author

While there are typically more edits and files than I'd normally include in a PR, I hope the small changes make for a quick review.

Happy to consider any language changes you don't agree with, and welcome PR review comments. 👍

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SeanKilleen and others added 2 commits May 25, 2021 11:37
Co-authored-by: Sam Chen <chenxsan@gmail.com>
Co-authored-by: Sam Chen <chenxsan@gmail.com>
@SeanKilleen
Copy link
Contributor Author

@chenxsan update;

✅ CLA Signed
✅ Suggestions merged in
❔ Added a question to the last piece of review.

I think once we sync up on that last question, this should be good to go. Thanks for being open to the PR!

@chenxsan chenxsan closed this May 26, 2021
@chenxsan chenxsan reopened this May 26, 2021
Since we'd changed the header text.
@SeanKilleen
Copy link
Contributor Author

@chenxsan I've added the redirect as requested. I think at this point all feedback items have been addressed. 👍

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Revise "imposter syndrome" words
2 participants