Skip to content

docs(watch): Update watchOptions types #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2020
Merged

docs(watch): Update watchOptions types #4190

merged 2 commits into from
Nov 21, 2020

Conversation

beejunk
Copy link
Contributor

@beejunk beejunk commented Nov 21, 2020

The ignored property of watchOptions no longer accepts an array of anymatch patterns, and instead accepts an array of string glob patterns.

This PR updates the watchOptions.ignored types to reflect this change. Also adds an additional example.

Closes #11903

Update `watchOptions` type to reflect what is allowed by `watchpack`. Also adds an additional example.

Closes #11903
@vercel
Copy link

vercel bot commented Nov 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/q8g48gjhm
✅ Preview: https://webpack-js-org-git-watchoptions-types-update.webpack-docs.vercel.app

@beejunk
Copy link
Contributor Author

beejunk commented Nov 21, 2020

Whoops, I realize now my issue reference is for an issue in the webpack repo. This is the issue that I believe would be addressed by this PR: webpack/webpack#11903

@chenxsan chenxsan merged commit b53c9b5 into webpack:master Nov 21, 2020
@beejunk beejunk deleted the watchoptions-types-update branch November 21, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants