Skip to content

chore: documentated non extensiblity of hooks for v5 #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

chore: documentated non extensiblity of hooks for v5 #3532

wants to merge 13 commits into from

Conversation

anikethsaha
Copy link
Member

close #2411

@montogeek montogeek added the API label Feb 13, 2020
EugeneHlushko
EugeneHlushko requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, besides the formatting changes, please revert all formatting changes they are not necessary and make it harder to review

P.S. removing trailing spaces looks good, keep them

@anikethsaha
Copy link
Member Author

@EugeneHlushko I am not getting why diff is showing a new line whereas the line numbers are correct

57
- // github diff showing new line
58

These are not changed in my local. can you please check it

@anikethsaha
Copy link
Member Author

cc @EugeneHlushko @montogeek can you review this

@EugeneHlushko
Copy link
Member

@anikethsaha i think the easiest way for you is to branch of recent master again and only add the related changes from this PR. Looks like your code editor might have done some auto-formatting

@snitin315 snitin315 mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veratriz Veratriz Veratriz approved these changes

@sokra sokra Awaiting requested review from sokra

@montogeek montogeek Awaiting requested review from montogeek

@EugeneHlushko EugeneHlushko Awaiting requested review from EugeneHlushko

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document webpack change: Freeze hooks to prevent deopts
4 participants
@anikethsaha @EugeneHlushko @Veratriz @montogeek