docs(plugins): clarify function provided to splitChunks.name #3118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Preview is ready Built with commit f9e6efd https://deploy-preview-3118--webpackjsorg-netlify.netlify.com |
montogeek
reviewed
Jun 13, 2019
|
Had done some research last night: https://github.com/webpack/webpack.js.org/pull/3120/files |
|
Did not see your PR attempt earlier @ryandrew14 |
|
How do I re-trigger the CLA check? |
|
By reopening the PR |
EugeneHlushko
approved these changes
Jun 14, 2019
|
I can't merge this myself, could you go for it @EugeneHlushko? |
|
@ryandrew14 this needs an action from @montogeek |
montogeek
approved these changes
Jun 14, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small update to the docs for the SplitChunksPlugin's name option. I found using this function to be really esoteric, and would love to clarify even more than I have here. The problem with that is that the
moduleandchunksarguments provided are esoteric themselves, meaning that documenting the arguments would likely lead to more confusion than help.The docs I'm sending helped me accomplish my goal with the function, and have helped other people who are confused as well. I believe it to be sufficient for most use cases for this function.
Quick edit: also takes part of #3116. I also just signed the CLA so that should be all set now.