-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
update: service worker docs #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updatesd
|
Preview is ready Built with commit b03370f https://deploy-preview-3091--webpackjsorg-netlify.netlify.com |
Why opening a new PR instead of updating the previous one? |
I should have posted in the other PR. I was failing linting in the last one. The other PR was made with the github edit feature. I wanted to pull down the project and make sure I didn't fail linting again. |
I signed CLI's from both CLI's shold I just rebase with one commit from one account? Sorry about this. |
Is travis down? It's been hanging all day :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good catch, although there is no need to duplicate examples of configs over the docs. Lets link to existing ones. Also changed the name of DevServer to be consistent with documentation.
If no objection please commit suggestion and remove the webpack.config.js....
example so that it will be good to merge
I think everything is passing on my end and I updated the PR with your feedback. Lmk if there's anything else you need on my end. Thanks again. |
@EugeneHlushko Please re review |
anything else that needs to get updated on my end? |
No, thanks! |
users need to write dist to disk in order to user http-server
https://stackoverflow.com/questions/41928358/webpack-how-to-compile-write-on-disk-and-serve-static-content-js-css-using-w/41928812#41928812
and
https://github.com/webpack/webpack-dev-server/releases/tag/v3.1.10
in favor of #3089