Skip to content

update: service worker docs #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2019
Merged

update: service worker docs #3091

merged 5 commits into from
Jun 11, 2019

Conversation

benschac
Copy link
Contributor

@benschac benschac commented Jun 3, 2019

@jsf-clabot
Copy link

jsf-clabot commented Jun 3, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@netlify
Copy link

netlify bot commented Jun 3, 2019

Preview is ready

Built with commit b03370f

https://deploy-preview-3091--webpackjsorg-netlify.netlify.com

@montogeek
Copy link
Member

Why opening a new PR instead of updating the previous one?

@benschac
Copy link
Contributor Author

benschac commented Jun 3, 2019

I should have posted in the other PR. I was failing linting in the last one. The other PR was made with the github edit feature. I wanted to pull down the project and make sure I didn't fail linting again.

@benschac
Copy link
Contributor Author

benschac commented Jun 5, 2019

I signed CLI's from both CLI's shold I just rebase with one commit from one account? Sorry about this.

@hiroppy hiroppy closed this Jun 5, 2019
@hiroppy hiroppy reopened this Jun 5, 2019
@benschac
Copy link
Contributor Author

benschac commented Jun 6, 2019

Is travis down? It's been hanging all day :(

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good catch, although there is no need to duplicate examples of configs over the docs. Lets link to existing ones. Also changed the name of DevServer to be consistent with documentation.

If no objection please commit suggestion and remove the webpack.config.js.... example so that it will be good to merge

@benschacprolific
Copy link

I think everything is passing on my end and I updated the PR with your feedback. Lmk if there's anything else you need on my end.

Thanks again.

@montogeek
Copy link
Member

@EugeneHlushko Please re review

@benschacprolific
Copy link

anything else that needs to get updated on my end?

@montogeek montogeek merged commit 9071d8b into webpack:master Jun 11, 2019
@montogeek
Copy link
Member

No, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants