Skip to content

fix errors in caching.md #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2019
Merged

fix errors in caching.md #3059

merged 3 commits into from
Jun 13, 2019

Conversation

chenyinkai
Copy link
Contributor

  1. use new CleanWebpackPlugin() instead of new CleanWebpackPlugin(['dist'])
  2. use hash instead of contenthash

@chenyinkai
fix errors in caching.md
14e3f93 
1. use `new CleanWebpackPlugin()` instead of `new CleanWebpackPlugin(['dist'])`
2. use `hash` insteadif `contenthash `
@jsf-clabot
Copy link

jsf-clabot commented May 23, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@netlify
Copy link

netlify bot commented May 23, 2019 •
edited
Loading

Preview is ready

Built with commit d793b72

https://deploy-preview-3059--webpackjsorg-netlify.netlify.com

@montogeek montogeek self-assigned this May 23, 2019
@montogeek montogeek removed their assignment May 23, 2019
@chenyinkai chenyinkai closed this May 25, 2019
@chenyinkai chenyinkai reopened this May 25, 2019
EugeneHlushko
EugeneHlushko reviewed May 30, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin call change looks valid, but why changing hash to contenthash ? @chenyinkai

@chenyinkai
Copy link
Contributor Author

chenyinkai commented Jun 13, 2019 •
edited
Loading

Sorry, this seems to be my fault. stackoverflow.

  1. use new CleanWebpackPlugin() instead of new CleanWebpackPlugin(['dist'])
  2. use hash instead of contenthash

@EugeneHlushko

@montogeek montogeek merged commit 2f99ec9 into webpack:master Jun 13, 2019
@montogeek
Copy link
Member

Thanks!

@EugeneHlushko
Copy link
Member

Yup all good thx for ping @chenyinkai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko left review comments

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyinkai @jsf-clabot @montogeek @EugeneHlushko