Skip to content

CleanWebpackPlugin | Requires a config object #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

chalkWood
Copy link
Contributor

@chalkWood chalkWood commented Mar 17, 2019

new CleanWebpackPlugin() | requires a config object than an array

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Remove these instructions from your PR as they are for your eyes only.

new CleanWebpackPlugin() | requires a config object than an array
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@montogeek montogeek closed this Mar 17, 2019
@montogeek montogeek reopened this Mar 17, 2019
@montogeek
Copy link
Member

Please also update the dependency in the package.json

Copy link
Member

@montogeek montogeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update dependency version

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EugeneHlushko
Copy link
Member

@montogeek which package.json do you mean? i dont see us asking for specific version in the guides

@montogeek
Copy link
Member

We don't ask about it, but it is there:
image

image
image

@EugeneHlushko
Copy link
Member

Ah there it is, i couldn't find it with algolia :)

@EugeneHlushko
Copy link
Member

@montogeek lets get this one in and i'll do a follow up ?

@montogeek montogeek merged commit 761612b into webpack:master Mar 19, 2019
@montogeek
Copy link
Member

Thanks!

1 similar comment
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants