fix(configuration): correcting grammar #2781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byzyk
reviewed
Jan 28, 2019
| @@ -10,9 +10,9 @@ contributors: | |||
| - zefman | |||
| --- | |||
|
|
|||
| The `externals` configuration option provides a way of excluding dependencies from the output bundles. Instead, the created bundle relies on that dependency to be present in the consumer's environment. This feature is typically most useful to __library developers__, however there are a variety of applications for it. | |||
| The `externals` configuration option provides a way of excluding dependencies from the output bundles. Instead, the created bundle relies on that dependency to be present in the consumer's environment. This feature is typically most useful to __library developers__, however, there are a variety of applications for it. | |||
There was a problem hiding this comment.
I'm not sure whether it would make more sense if we would start a new sentence at However part.
There was a problem hiding this comment.
I think, with a new line, it will make more sense. So, should I change it?
There was a problem hiding this comment.
I mean I guess it's fine even the way it is now. Not a big deal. Thanks!
EugeneHlushko
added
Grammar
EugeneHlushko
approved these changes
Feb 11, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.