Skip to content

docs(config): Highlight merging of chunks when splitChunks.name is a … #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 11, 2019
Merged

docs(config): Highlight merging of chunks when splitChunks.name is a … #2777

merged 6 commits into from
Feb 11, 2019

Conversation

yaaooo
Copy link
Contributor

@yaaooo yaaooo commented Jan 21, 2019

Fixes #2763

@yaaooo
Copy link
Contributor Author

yaaooo commented Feb 7, 2019

@montogeek Does this look good?

EugeneHlushko
EugeneHlushko requested changes Feb 8, 2019
View reviewed changes
EugeneHlushko
EugeneHlushko requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just figured out another small improvement

@EugeneHlushko @yaaooo
Update src/content/plugins/split-chunks-plugin.md
6e0a521 
Co-Authored-By: superburrito <chuayaohui@gmail.com>
@EugeneHlushko EugeneHlushko merged commit ed00e58 into webpack:master Feb 11, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvdutt dhruvdutt dhruvdutt approved these changes

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaaooo @EugeneHlushko @dhruvdutt @montogeek