Skip to content

lint(links) disable link linter on travis #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Jan 13, 2019

disable links linter on travis

ok 99 load dist/guides/public-path
ok 100 load dist/guides/integrations
ok 101 load dist/api/cli
ok 102 load dist/api/node
ok 103 load dist/api/module-methods
ok 104 load dist/loaders
ok 105 load dist/concepts/loaders
ok 106 load dist/api
ok 107 load dist/writers-guide/index.html
_http_client.js:114
      throw new ERR_UNESCAPED_CHARACTERS('Request path');
      ^

TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters
    at new ClientRequest (_http_client.js:114:13)
    at Object.request (https.js:280:10)
    at Immediate.dispatchRequest (webpack.js.org/node_modules/teepee/lib/Teepee.js:605:79)
    at runCallback (timers.js:694:18)
    at tryOnImmediate (timers.js:665:5)
    at processImmediate (timers.js:647:5)
error Command failed with exit code 1.

@Munter
Copy link
Collaborator

Munter commented Jan 14, 2019

You know, the reason for this failure is most likely that a link is wrong. Why would we remove the link checker instead of fixing the problem? Obviously the error handling in this case is not so pretty, but could we at least try to fix the problem, either in the docs or in hyperlink?

@Munter
Copy link
Collaborator

Munter commented Jan 15, 2019

Closing in favor of solutions worked out in #2762 and webpack-contrib/cache-loader#60

@Munter Munter closed this Jan 15, 2019
@montogeek montogeek deleted the rebuild-links-failing branch January 15, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants