Skip to content

fix(infra) Add return to actually replace readme links #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2018
Merged

fix(infra) Add return to actually replace readme links #2451

merged 1 commit into from
Aug 17, 2018

Conversation

montogeek
Copy link
Member

@montogeek montogeek requested a review from Munter August 17, 2018 13:39
@montogeek montogeek mentioned this pull request Aug 17, 2018
Merged
12 tasks
Munter
Munter approved these changes Aug 17, 2018
View reviewed changes
Copy link
Collaborator

@Munter Munter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear :)

@Munter
Copy link
Collaborator

Munter commented Aug 17, 2018

So there are 3 errors in the link checks:

  • json-loader is linking to /guides/migrating/#json-loader-is-not-required-anymore, which should be migrate/3#json-loader-is-not-required-anymore. I can't make a PR to update that README becasue the repo is archived

The two remaining ones might be false negatives. I'll have to look into that

@Munter
Copy link
Collaborator

Munter commented Aug 17, 2018

Yup. Last two errors of content-type-mismatch are false negatives. Fixed in the latest version of assetgraph, which hyperlink is not yet upgraded to because of a different regression in upgrading

@montogeek
Copy link
Member Author

We could setup a Redirect, it would solve the issue

@montogeek montogeek merged commit 440c2a0 into rebuild Aug 17, 2018
@montogeek montogeek deleted the rebuild-fix-readme-badges branch August 17, 2018 22:54
Munter added a commit that referenced this pull request Aug 22, 2018
@Munter
Merge pull request #2453 from webpack/rebuild-fix-readme-badges
7340aca 
Fix regressions from #2451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Munter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montogeek @Munter