feature: pre-commit hooks #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montogeek
approved these changes
Jun 11, 2018
byzyk
commented
Jun 11, 2018
package.json
Outdated
| @@ -39,6 +39,11 @@ | |||
| "test": "npm run lint", | |||
| "sitemap": "cd build && sitemap-static --prefix=https://webpack.js.org/ > sitemap.xml" | |||
| }, | |||
| "husky": { | |||
| "hooks": { | |||
| "pre-commit": "yarn test" | |||
There was a problem hiding this comment.
@montogeek as per our discussion in another PR I guess we should revert to npm run here as well before merging
dhruvdutt
approved these changes
Jun 11, 2018
|
This one is ready to go. |
|
What is the difference between this husky release candidate and the last stable one? |
|
In the RC version, you define hooks in the separate Here is the full changelog. |
|
Thanks! |
|
@byzyk If you have time, please add lint-staged too. We are losing time checking for files that shouldn't be linted, for example, bash scripts. |
|
@montogeek sure man! will pick it up at the earliest, shouldn't take much time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #2226