-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
replace 'bundle.js' with 'main.js' in examples #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'npx webpack' default output file is no longer bundle.js but rather main.js. corrected accordingly.
@EugeneHlushko I don't understand this change. |
wasnt this already collected and merged? We changed to the opposite |
i think i found the root cause of this one @montogeek As soon as you have This is how we got different results while testing this behaviour by running the exact same command Maybe it makes sense to remove the |
@EugeneHlushko i got 'main.js' as output file even without having a webpack.config.js file. |
Exactly, thats what i'm also trying to say. Without config you get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry forgot to approve
Thanks |
'npx webpack' default output file 'main.js',
while in examples 'bundle.js' is being used.
corrected examples accordingly.