Skip to content

Document webpackIgnore option #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 13, 2018
Merged

Document webpackIgnore option #2101

merged 7 commits into from
Aug 13, 2018

Conversation

FadySamirSadek
Copy link
Member

Solves #2077

montogeek
montogeek approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@montogeek montogeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add an example?

@FadySamirSadek
Copy link
Member Author

@montogeek I have no clue why the build is failing here , but it seems like a code error not with the text

@montogeek
Copy link
Member

Don't worry about it, infrastructure problems :) We could try again later.

montogeek
montogeek reviewed Jul 11, 2018
View reviewed changes
src/content/api/module-methods.md Outdated
@@ -90,6 +91,12 @@ import(
`./locale/${language}`
);
```
```js
import(/* webpackIgnore: true */ 'ignored-module.js')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ;

montogeek
montogeek requested changes Jul 11, 2018
View reviewed changes
Copy link
Member

@montogeek montogeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@montogeek
Copy link
Member

@FadySamirSadek There is some new Markdown errors:
https://travis-ci.org/webpack/webpack.js.org/builds/402943423?utm_source=github_status&utm_medium=notification

Could you please take a look? Thanks!

@montogeek montogeek merged commit 60c38ae into webpack:master Aug 13, 2018
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Assignees
No one assigned
Labels
API Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FadySamirSadek @montogeek @dhruvdutt