Skip to content

Update define-plugin.md #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Update define-plugin.md #1977

merged 2 commits into from
Jun 12, 2018

Conversation

foreheadSniffer
Copy link
Contributor

@foreheadSniffer foreheadSniffer commented Apr 3, 2018

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Remove these instructions from your PR as they are for your eyes only.

@jsf-clabot
Copy link

jsf-clabot commented Apr 3, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@nveenjain
Copy link
Member

@foreheadSniffer , Thanks for the PR, but could you please sign the CLA first, so that we can proceed with this PR.

@dhruvdutt
Copy link
Member

@foreheadSniffer Any update on this? :)

@montogeek montogeek merged commit 715fa9c into webpack:master Jun 12, 2018
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants