Skip to content

Fixes reference to output bundle in Getting Started guide #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gingi
Copy link

@gingi gingi commented Apr 2, 2018

With no arguments, the bundle that npx webpack outputs in dist/ is main.js, not bundle.js. Confirmed with both webpack@4.0.1 (the version referenced in the guide) and webpack@4.4.1 (latest stable). This commit renames all references (bundle.jsmain.js) to avoid requiring new users from specifying unnecessary parameters.

@gingi
Copy link
Author

gingi commented Apr 3, 2018

I now notice that bundle.js is assumed to be the output in subsequent guides. It might be worthwhile modifying the Getting Started guide to rename it from main.js to bundle.js when the config file is introduced. I'll be happy to make that change to maintain parity with the other guides.

@gingi gingi closed this Apr 3, 2018
@gingi gingi reopened this Apr 3, 2018
@montogeek
Copy link
Member

Thanks for your contribution, unfortunately it was already fixed in #1951, I advice check previous PRs before submitting yours.

@montogeek montogeek closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants