Update TypeScript configuration example to TS 2.7 #1926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated snippet uses the same syntax as in any ES6/ES2015 based module imports in vanilla JavaScript thanks to new features from TypeScript 2.7 or newer The relevant not has been added to the sample to mention these new configuration compiler properties. Thanks!
montogeek
approved these changes
Mar 19, 2018
montogeek
approved these changes
Mar 19, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the TypeScript configuration sample slightly trying to simplify the code - and make it on the same level as any ES6/ES2015 module based code.
The TS 2.7 allows - with simple configuration change in
tsconfig.json- to unify use of imports in vanilla JavaScript module and TypeScript module source code. This remove needs of using* asin source code.The text of the note has been extended to add note about these compiler additional configuration properties - which should be helpful for users with some TypeScript background. The unfortunate outcome is that the entire length of the section is slightly increased.
Here is a quick demo project that was setup based on existing (and this one) configuration notes to show that it is working setup:
https://github.com/peterblazejewicz/webpack-guides-typescript
Thanks!