Skip to content

fixed line 62 spelling 'cosnole' -> 'console' #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2018
Merged

fixed line 62 spelling 'cosnole' -> 'console' #1912

merged 1 commit into from
Mar 15, 2018

Conversation

j-d-b
Copy link
Contributor

@j-d-b j-d-b commented Mar 14, 2018

just a typo fix~

@montogeek montogeek merged commit 599b9d8 into webpack:master Mar 15, 2018
@montogeek
Copy link
Member

Thank you!

dear-lizhihua
dear-lizhihua reviewed Mar 15, 2018
View reviewed changes
src/content/guides/development.md
@@ -59,7 +59,7 @@ __src/print.js__
``` diff
export default function printMe() {
- console.log('I get called from print.js!');
+ cosnole.log('I get called from print.js!');
+ console.log('I get called from print.js!');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a spelling error.

line 55:

Now let's make sure we have something to debug, so let's create an error in our `print.js` file:

Copy link
Member

@montogeek montogeek Mar 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, completely missed it, D'oh!

montogeek added a commit that referenced this pull request Mar 15, 2018
@montogeek
Revert "docs(guides) : Fixed line 62 spelling 'cosnole' -> 'console' (#…
2cf9766 
…1912)"

This reverts commit 599b9d8.
@montogeek montogeek mentioned this pull request Mar 15, 2018
Closed
montogeek pushed a commit that referenced this pull request Mar 16, 2018
@salazarluisf @montogeek
fix(guides): Revert #1912 "fixed line 62 spelling 'cosnole' -> 'conso…
3e9b9da 
…le'"

Fixes supposed "error" on line 62, which is not an actual error and does not produce an error to debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

@dear-lizhihua dear-lizhihua dear-lizhihua left review comments

Assignees
No one assigned
Labels
Correction Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-d-b @montogeek @dear-lizhihua